Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	Chris Sosnin <k.sosnin@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] box: remove unicode_ci for functions
Date: Tue, 10 Dec 2019 15:44:21 +0300	[thread overview]
Message-ID: <20191210124421.7e2jnir2mj5wdwkl@tarantool.org> (raw)
In-Reply-To: <20191210081958.GB21413@atlas>

Hello,

On 10 дек 11:19, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/12/10 10:22]:
> > >> We are team of Tarantool developers working for MailRU Group.
> > > 
> > > Actually this decision was made without any discussions - it was
> > > quickly hacked in back in 2018. Maybe you and Nikita had some
> > > discussion prompted by Peter's firm stance that we should
> > > uppercase, but that was it. I protested several times while I
> > > was still on board but had not anticipated how bad the solution
> > > would turn out to be when it is implemented to follow through on
> > > time. Now it is still not to late - bit it's getting more late
> > > every day.
> > > 
> > > What we learned since then is that every single newbie trips over
> > > it.
> > > 
> > > 
> > 
> > Well, you was exactly the person who voted for uppercase of
> > everything. Peter was for it too, but you made the decision,
> > and you at that time had a right to forbid it.
> 
> I agree I am partly to blame because I had a chance to object 
> and I didn't do it strongly enough at the time. 
> In any case, I changed my mind seeing how it worked out.

This patch is not about matter which is being discussed in this
thread. To discuss such major features (like `lets do everything
CI`) we have `discussions` mailing list and github issues.
I recommend you to move there with such proposals.

The patch LGTM. I've checked it into master.

--
Regards, Kirill Yukhin

      reply	other threads:[~2019-12-10 12:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 23:39 Chris Sosnin
2019-11-30 20:34 ` Konstantin Osipov
2019-12-01 14:12   ` k.sosnin
2019-12-01 14:36   ` Vladislav Shpilevoy
2019-12-02  7:07     ` Konstantin Osipov
2019-12-02 14:36       ` Nikita Pettik
2019-12-02 14:49         ` Konstantin Osipov
2019-12-06 11:42       ` Kirill Yukhin
2019-12-06 20:17         ` Konstantin Osipov
2019-12-09 11:06           ` Kirill Yukhin
2019-12-09 11:24             ` Konstantin Osipov
2019-12-09 13:25               ` Kirill Yukhin
2019-12-09 13:39                 ` Konstantin Osipov
2019-12-09 14:07                   ` Nikita Pettik
2019-12-09 23:09                   ` Vladislav Shpilevoy
2019-12-10  8:19                     ` Konstantin Osipov
2019-12-10 12:44                       ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210124421.7e2jnir2mj5wdwkl@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=k.sosnin@tarantool.org \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] box: remove unicode_ci for functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox