From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto
Date: Mon, 9 Dec 2019 10:21:40 +0300 [thread overview]
Message-ID: <20191209072140.GD433@atlas> (raw)
In-Reply-To: <a5844a06bb9d4046bd8d01bf11c94ce2c8adc775.1575833120.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/12/08 23:47]:
The danger of reporting, self-assigning and fixing a bug is that
... it might be not a bug.
Users should know that iproto fibers are pooled, not
created/destroyed on demand. So fiber local storage is simply not
making any sense for them.
A proper fix would be to disable fiber local storage for these
fibers, not try to make it work.
Even though your patch "works", it is pretty much useless.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-12-09 7:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 19:28 [Tarantool-patches] [PATCH 0/2] Fiber storage leak Vladislav Shpilevoy
2019-12-08 19:28 ` [Tarantool-patches] [PATCH 1/2] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy
2019-12-11 23:57 ` Igor Munkin
2019-12-12 8:50 ` Konstantin Osipov
2019-12-12 23:38 ` Vladislav Shpilevoy
2019-12-13 10:44 ` Igor Munkin
2019-12-08 19:28 ` [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy
2019-12-09 7:21 ` Konstantin Osipov [this message]
2019-12-09 23:31 ` Vladislav Shpilevoy
2019-12-10 8:21 ` Konstantin Osipov
2019-12-10 8:32 ` Konstantin Osipov
2019-12-10 22:59 ` Vladislav Shpilevoy
2019-12-11 7:08 ` Konstantin Osipov
2019-12-11 21:23 ` Vladislav Shpilevoy
2019-12-12 0:00 ` Igor Munkin
2019-12-12 23:37 ` Vladislav Shpilevoy
2019-12-13 13:35 ` Igor Munkin
2019-12-12 8:46 ` Konstantin Osipov
2019-12-13 0:02 ` Vladislav Shpilevoy
2019-12-13 7:58 ` Konstantin Osipov
2019-12-13 23:11 ` Vladislav Shpilevoy
2019-12-14 12:26 ` Konstantin Osipov
2019-12-14 12:30 ` Konstantin Osipov
2019-12-14 12:33 ` Konstantin Osipov
2019-12-14 16:49 ` Vladislav Shpilevoy
2019-12-14 20:59 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209072140.GD433@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox