From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup submodules Date: Mon, 9 Dec 2019 06:11:55 +0300 [thread overview] Message-ID: <20191209031155.iukodx2tkath4z4u@tkn_work_nb> (raw) In-Reply-To: <f1e01f8132a60ef999d027d670c0ef589ec6143a.1573125147.git.avtikhon@tarantool.org> All jobs are run in a docker or in a virtual machine. How can we get a dirty directory for a run? I don't mind if it solves some problems, but now I don't understand what the problems are. WBR, Alexander Turenko. On Thu, Nov 07, 2019 at 02:13:46PM +0300, Alexander V. Tikhonov wrote: > Found that durring runs on Gitlab-CI workspaces durring -> during > some extra files from tests from the submodules > like src/lib/small/* leaves in subdirectories, > which produce warning messages at the Gitlab-CI > run log, to avoid of it the submodules cleanup Which kind of warnings? > it needed before each Gitlab-CI job. it -> is? > > Closes #4258 I would treat the issue as a more wide problem, then CI's one (Kirill met it locally). I propose to left the issue open, but mention it like: | Follows on #4258. > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4258-clean-ws-full-ci > Issue: https://github.com/tarantool/tarantool/issues/4258 > > .gitlab-ci.yml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 04bb4b1cc..91326b218 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -4,6 +4,9 @@ stages: > variables: > GITLAB_MAKE: "make -f .gitlab.mk" > > +before_script: > + - git submodule foreach git clean -xfd > + 1. Run `git clean -xfd` too (not only submodules). 2. Add --recursive after 'foreach' just in case. 3. Enclose 'git clean -xfd' for submodules into quotes: otherwise it does not work on some git versions (I found that after some update). For the reference, my one-liner that always work (at least for me): $ git clean -xfd; git submodule foreach --recursive 'git clean -xfd' > # Jobs templates > > .release_only_template: &release_only_definition > -- > 2.17.1 >
next prev parent reply other threads:[~2019-12-09 3:12 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 11:13 Alexander V. Tikhonov 2019-12-09 3:11 ` Alexander Turenko [this message] 2019-12-09 4:07 ` Alexander Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191209031155.iukodx2tkath4z4u@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup submodules' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox