Tarantool development patches archive
 help / color / mirror / Atom feed
From: olegrok@tarantool.org
To: tarantool-patches@dev.tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>
Subject: [Tarantool-patches] [PATCH] httpc: consider "verbose" option correctly
Date: Sat,  7 Dec 2019 16:10:14 +0300	[thread overview]
Message-ID: <20191207131014.84735-1-olegrok@tarantool.org> (raw)

From: Oleg Babin <babinoleg@mail.ru>

Before this patch if user passed {verbose = false}
to http client it was considered as "true"

This patch fixes such behaviour and takes into account
user's value
---
 src/lua/httpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lua/httpc.c b/src/lua/httpc.c
index a8e3e2525..4d703d711 100644
--- a/src/lua/httpc.c
+++ b/src/lua/httpc.c
@@ -302,7 +302,7 @@ luaT_httpc_request(lua_State *L)
 
 	lua_getfield(L, 5, "verbose");
 	if (!lua_isnil(L, -1) && lua_isboolean(L, -1))
-		httpc_set_verbose(req, true);
+		httpc_set_verbose(req, lua_toboolean(L, -1));
 	lua_pop(L, 1);
 
 	lua_getfield(L, 5, "interface");
-- 
2.23.0

             reply	other threads:[~2019-12-07 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07 13:10 olegrok [this message]
2019-12-07 13:35 ` Sergey Ostanevich
2019-12-10 15:35 ` Alexander Turenko
2019-12-19  8:12 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207131014.84735-1-olegrok@tarantool.org \
    --to=olegrok@tarantool.org \
    --cc=babinoleg@mail.ru \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] httpc: consider "verbose" option correctly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox