From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: remove unicode_ci for functions
Date: Fri, 6 Dec 2019 23:17:18 +0300 [thread overview]
Message-ID: <20191206201718.GA7299@atlas> (raw)
In-Reply-To: <20191206114244.umbeo556b2atuhjm@tarantool.org>
* Kirill Yukhin <kyukhin@tarantool.org> [19/12/06 23:09]:
> > > >> Unicode_ci collation breaks the general
> > > >> rule for objects naming, so we remove it
> > > >> in version 2.3.1
> > > >
> > > > The code works according to RFC.
> > > >
> > > > There is a justification for this behaviour in RFC.
> >
> > Please see my reply with an explanation. The RFC was written
> > presuming https://github.com/tarantool/tarantool/issues/4467
> > will be fixed.
>
> It was clearly pointed that proposal in #4467 is broken by
> design. Please see [1] for details. Having that said I think
> we should consider the proposal rejected and won't try to invent
> any new workarounds.
>
> [1] - https://github.com/tarantool/tarantool/issues/4467#issuecomment-527210486 and later.
Even if you think the proposal is broken the problem is there
and needs resolution, not aggravation.
Re initial proposal being broken I admitted it in the comment.
We'll have to do an incompatible change and violate ANSI - in
order to make the product usable. I suggested to add a
case-insensitive unique index to every system space already.
As to the suggestion being broken - it will allow one to get rid
of uppercase-before-store and be mostly ansi compatible.
It's less broken what we have now.
--
Konstantin Osipov, Moscow, Russia
https://scylladb.com
next prev parent reply other threads:[~2019-12-06 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 23:39 Chris Sosnin
2019-11-30 20:34 ` Konstantin Osipov
2019-12-01 14:12 ` k.sosnin
2019-12-01 14:36 ` Vladislav Shpilevoy
2019-12-02 7:07 ` Konstantin Osipov
2019-12-02 14:36 ` Nikita Pettik
2019-12-02 14:49 ` Konstantin Osipov
2019-12-06 11:42 ` Kirill Yukhin
2019-12-06 20:17 ` Konstantin Osipov [this message]
2019-12-09 11:06 ` Kirill Yukhin
2019-12-09 11:24 ` Konstantin Osipov
2019-12-09 13:25 ` Kirill Yukhin
2019-12-09 13:39 ` Konstantin Osipov
2019-12-09 14:07 ` Nikita Pettik
2019-12-09 23:09 ` Vladislav Shpilevoy
2019-12-10 8:19 ` Konstantin Osipov
2019-12-10 12:44 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206201718.GA7299@atlas \
--to=kostja.osipov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: remove unicode_ci for functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox