Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH] app: increase max recursion depth for encoding/decoding
@ 2019-12-06 10:04 Chris Sosnin
  2019-12-06 11:14 ` Kirill Yukhin
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Sosnin @ 2019-12-06 10:04 UTC (permalink / raw)
  To: tarantool-patches

It was requested to be raised from 32 to 128

Closes #4670
---
branch: https://github.com/tarantool/tarantool/compare/ksosnin/gh-4670-encoding-depth
issue: https://github.com/tarantool/tarantool/issues/4670

 src/lua/utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lua/utils.c b/src/lua/utils.c
index 7f7bf4776..d5122ee2c 100644
--- a/src/lua/utils.c
+++ b/src/lua/utils.c
@@ -236,7 +236,7 @@ static struct {
 	OPTION(LUA_TBOOLEAN, encode_sparse_convert, 1),
 	OPTION(LUA_TNUMBER,  encode_sparse_ratio, 2),
 	OPTION(LUA_TNUMBER,  encode_sparse_safe, 10),
-	OPTION(LUA_TNUMBER,  encode_max_depth, 32),
+	OPTION(LUA_TNUMBER,  encode_max_depth, 128),
 	OPTION(LUA_TBOOLEAN, encode_deep_as_nil, 0),
 	OPTION(LUA_TBOOLEAN, encode_invalid_numbers, 1),
 	OPTION(LUA_TNUMBER,  encode_number_precision, 14),
@@ -245,7 +245,7 @@ static struct {
 	OPTION(LUA_TBOOLEAN, encode_invalid_as_nil, 0),
 	OPTION(LUA_TBOOLEAN, decode_invalid_numbers, 1),
 	OPTION(LUA_TBOOLEAN, decode_save_metatables, 1),
-	OPTION(LUA_TNUMBER,  decode_max_depth, 32),
+	OPTION(LUA_TNUMBER,  decode_max_depth, 128),
 	{ NULL, 0, 0, 0},
 };

--
2.21.0 (Apple Git-122.2)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Tarantool-patches] [PATCH] app: increase max recursion depth for encoding/decoding
  2019-12-06 10:04 [Tarantool-patches] [PATCH] app: increase max recursion depth for encoding/decoding Chris Sosnin
@ 2019-12-06 11:14 ` Kirill Yukhin
  0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2019-12-06 11:14 UTC (permalink / raw)
  To: Chris Sosnin; +Cc: tarantool-patches

Hello,

On 06 дек 13:04, Chris Sosnin wrote:
> It was requested to be raised from 32 to 128
> 
> Closes #4670
> ---
> branch: https://github.com/tarantool/tarantool/compare/ksosnin/gh-4670-encoding-depth
Nit: please, use proper link to the branch, w/o `compare`

> issue: https://github.com/tarantool/tarantool/issues/4670

Your patch it OK. I've checked it into 2.2 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-06 11:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 10:04 [Tarantool-patches] [PATCH] app: increase max recursion depth for encoding/decoding Chris Sosnin
2019-12-06 11:14 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox