Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky box/gh-4627-session-use-after-free
Date: Fri, 6 Dec 2019 01:53:31 +0300	[thread overview]
Message-ID: <20191205225331.65eucxjrkgi7bbsy@tkn_work_nb> (raw)
In-Reply-To: <958ef3b3-ae42-2270-6e14-17f3788aadd4@tarantool.org>

LGTM.

Pushed to master, 2.2 and 1.10.

CCed Kirill.

WBR, Alexander Turenko.

On Thu, Dec 05, 2019 at 09:42:11PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> I submitted fixes to the branch.

> >> +-- This is a workaround for flakiness of the test
> >> +-- appearing when another test tries to connect to
> > 
> > I tentative that another test may access to a unix socket (tarantool's
> 
> I am sorry, but I don't understand - what do you mean as 'I tentative'?
> This is not a verb. You meant, that you guess, assume, doubt, investigated
> or something else?
> 
> I assume you've meant 'I doubt', as so there is a fix:

Exactly.

      reply	other threads:[~2019-12-05 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  0:05 Vladislav Shpilevoy
2019-12-04 11:35 ` Alexander Turenko
2019-12-05 20:42   ` Vladislav Shpilevoy
2019-12-05 22:53     ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205225331.65eucxjrkgi7bbsy@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky box/gh-4627-session-use-after-free' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox