From: Kirill Yukhin <kyukhin@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] fold: keep type of emitted CONV in sync with its mode
Date: Thu, 5 Dec 2019 16:09:33 +0300 [thread overview]
Message-ID: <20191205130933.jfhlbpohythxiac7@tarantool.org> (raw)
In-Reply-To: <7729408a83dbde42bc7c8a5fa1fd8ba6a7f7c40f.1575269331.git.imun@tarantool.org>
Hello,
On 02 дек 10:03, Igor Munkin wrote:
> From: Vyacheslav Egorov <vegorov@google.com>
>
> When emitting CONV make sure that its type matches its destination IRType.
>
> This keeps IR fully internally consistent with respect to types - i.e. if
> we push narrowing CONV Dt.St upwards through an arithmetic operation of type
> St we end up with arithmetic operation of type Dt and two convertions
> CONV Dt.St which narrow the operands.
>
> Igor Munkin:
> * added a test for the problem
> * backported the original patch to tarantool/luajit repo
> * stripped some words not related to the patch itself
>
> Fixes LuaJIT/LuaJIT#524
>
> Signed-off-by: Vyacheslav Egorov <vegorov@google.com>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
I've checked your patch into luajit repo and bumped new version
in Tarantool.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-12-05 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 7:03 Igor Munkin
2019-12-04 14:55 ` Sergey Ostanevich
2019-12-05 12:51 ` Igor Munkin
2019-12-05 13:09 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205130933.jfhlbpohythxiac7@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fold: keep type of emitted CONV in sync with its mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox