From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback
Date: Tue, 3 Dec 2019 21:02:57 +0300 [thread overview]
Message-ID: <20191203180257.GA4364@atlas> (raw)
In-Reply-To: <73ebdf94c8f03fca216de9141c6541870b1ed938.1575390549.git.lvasiliev@tarantool.org>
* Leonid Vasiliev <lvasiliev@tarantool.org> [19/12/03 19:36]:
> https://github.com/tarantool/tarantool/issues/4127
> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4127-WAL-thread-stucks
Looks like a great catch.
> We need to set a thread cancellation guard, because
> another thread may cancel the current thread
> (write() is a cancellation point in ev_async_send)
> and the activation of the ev_async watcher
> through ev_async_send will fail.
I still don't get from the explanation why it is relevant that
ev_async_send mustn't fail?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-12-03 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:33 Leonid Vasiliev
2019-12-03 18:02 ` Konstantin Osipov [this message]
2019-12-05 7:22 ` Leonid Vasiliev
2019-12-05 7:27 ` Konstantin Osipov
2019-12-23 12:44 ` Leonid Vasiliev
2019-12-23 12:55 ` Konstantin Osipov
2019-12-24 15:27 ` Leonid Vasiliev
2019-12-24 15:33 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203180257.GA4364@atlas \
--to=kostja.osipov@gmail.com \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox