From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] clear terminal state on panic
Date: Fri, 29 Nov 2019 17:53:10 +0300 [thread overview]
Message-ID: <20191129145310.GD18043@atlas> (raw)
In-Reply-To: <20191129130055.GH19879@uranus>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/11/29 16:31]:
> > +void
> > +tarantool_atexit(void)
> > +{
> > + /* Same checks as in tarantool_free() */
> > + if (getpid() != master_pid)
> > + return;
> > +
> > + if (!cord_is_main())
> > + return;
> > +
> > + free_rl_state();
> > +}
>
> As to me this is a way cleaner. Ack from my side.
> Lets wait for Kostya's opinion.
I'm happy with it, since it has a comment :)
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-29 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:15 Serge Petrenko
2019-11-26 20:56 ` Konstantin Osipov
2019-11-27 16:07 ` Cyrill Gorcunov
2019-11-27 21:51 ` Konstantin Osipov
2019-11-27 22:31 ` Cyrill Gorcunov
2019-11-29 11:06 ` Serge Petrenko
2019-11-29 11:15 ` Cyrill Gorcunov
2019-11-29 12:20 ` Serge Petrenko
2019-11-29 13:00 ` Cyrill Gorcunov
2019-11-29 14:53 ` Konstantin Osipov [this message]
2019-12-10 14:03 ` Kirill Yukhin
2019-12-23 14:29 ` Alexander Turenko
2020-01-13 11:14 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129145310.GD18043@atlas \
--to=kostja.osipov@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] clear terminal state on panic' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox