[Tarantool-patches] [PATCH v3] build: enable LUAJIT_ENABLE_PAIRSMM by default

[Tarantool-patches] [PATCH v3] build: enable LUAJIT_ENABLE_PAIRSMM by default

[Olga Arkhangelskaia]

Turn on LUAJIT_ENABLE_PAIRSMM flag for tarantool build.
Now __pairs/__ipairs metamethods are available.

Closes #4560
---
Branch:https://github.com/tarantool/tarantool/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit
v1:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012586.html
v2:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012626.html
Changes v2:
- fixed typos
Changes v3:
- fixed commit
- fixed issue num

 cmake/luajit.cmake | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
index 10df633d5..072db8269 100644
--- a/cmake/luajit.cmake
+++ b/cmake/luajit.cmake
@@ -217,6 +217,7 @@ macro(luajit_build)
         add_definitions(-DLUAJIT_USE_ASAN=1)
         set (luajit_ldflags ${luajit_ldflags} -fsanitize=address)
     endif()
+    add_definitions(-DLUAJIT_ENABLE_PAIRSMM=1)
     add_definitions(-DLUAJIT_SMART_STRINGS=1)
     # Add all COMPILE_DEFINITIONS to xcflags
     get_property(defs DIRECTORY PROPERTY COMPILE_DEFINITIONS)
-- 
2.20.1 (Apple Git-117)

Re: [Tarantool-patches] [PATCH v3] build: enable LUAJIT_ENABLE_PAIRSMM by default

[Igor Munkin]

Olya,

Thanks a lot, now the patch totally LGTM.

Cced Kirill to proceed with the patch.

On 27.11.19, Olga Arkhangelskaia wrote:
> Turn on LUAJIT_ENABLE_PAIRSMM flag for tarantool build.
> Now __pairs/__ipairs metamethods are available.
> 
> Closes #4560
> ---
> Branch:https://github.com/tarantool/tarantool/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit
> v1:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012586.html
> v2:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012626.html
> Changes v2:
> - fixed typos
> Changes v3:
> - fixed commit
> - fixed issue num

Side note: As Kostja mentioned in your recent patchset, the changelog
ought to be sorted in a reverse order according to our contribution
guide[1]. Please consider it for your further patches.

> 
>  cmake/luajit.cmake | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
> index 10df633d5..072db8269 100644
> --- a/cmake/luajit.cmake
> +++ b/cmake/luajit.cmake
> @@ -217,6 +217,7 @@ macro(luajit_build)
>          add_definitions(-DLUAJIT_USE_ASAN=1)
>          set (luajit_ldflags ${luajit_ldflags} -fsanitize=address)
>      endif()
> +    add_definitions(-DLUAJIT_ENABLE_PAIRSMM=1)
>      add_definitions(-DLUAJIT_SMART_STRINGS=1)
>      # Add all COMPILE_DEFINITIONS to xcflags
>      get_property(defs DIRECTORY PROPERTY COMPILE_DEFINITIONS)
> -- 
> 2.20.1 (Apple Git-117)
> 

-- 
Best regards,
IM

Re: [Tarantool-patches] [PATCH v3] build: enable LUAJIT_ENABLE_PAIRSMM by default

[Igor Munkin]

Oops, missed the link in the previous message.

> 
> Side note: As Kostja mentioned in your recent patchset, the changelog
> ought to be sorted in a reverse order according to our contribution
> guide[1]. Please consider it for your further patches.
> 

[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/developer_guidelines/#how-to-submit-a-patch-for-review

-- 
Best regards,
IM

Re: [Tarantool-patches] [PATCH v3] build: enable LUAJIT_ENABLE_PAIRSMM by default

[Kirill Yukhin]

Hello,

On 27 ноя 23:07, Olga Arkhangelskaia wrote:
> Turn on LUAJIT_ENABLE_PAIRSMM flag for tarantool build.
> Now __pairs/__ipairs metamethods are available.
> 
> Closes #4560

I've checked your patch into 1.10 2.2 and master.

--
Regards, Kirill Yukhin