Re: [Tarantool-patches] [PATCH v2] build: enables LUAJIT_ENABLE_PAIRSMM by default

[Igor Munkin <imun@tarantool.org>]

Olya,

Thanks, I see you've fixed some typos I mentioned in the previous
review. However there are still a couple left in the commit subject and
message. Please consider 2 comments below.

On 26.11.19, Olga Arkhangelskaia wrote:

1. Please, amend the predicate of your commit subject: it have to be in
the imperative mood.

> Turns on LUAJIT_ENABLE_PAIRSMM flag for tarantool build.
> Now __pairs/__ipairs metamethods are available.
> 
> Closes #4650

2. As Vlad already mentioned (good catch, Vlad, thanks a lot) the
changeset relates to #4560, not to #4650. Please adjust the issue number.

> ---
> Branch:https://github.com/tarantool/tarantool/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit
> v1:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012586.html
> 
> Changes v2:
> - fixed typos
> 
>  cmake/luajit.cmake | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
> index 10df633d5..072db8269 100644
> --- a/cmake/luajit.cmake
> +++ b/cmake/luajit.cmake
> @@ -217,6 +217,7 @@ macro(luajit_build)
>          add_definitions(-DLUAJIT_USE_ASAN=1)
>          set (luajit_ldflags ${luajit_ldflags} -fsanitize=address)
>      endif()
> +    add_definitions(-DLUAJIT_ENABLE_PAIRSMM=1)
>      add_definitions(-DLUAJIT_SMART_STRINGS=1)
>      # Add all COMPILE_DEFINITIONS to xcflags
>      get_property(defs DIRECTORY PROPERTY COMPILE_DEFINITIONS)
> -- 
> 2.20.1 (Apple Git-117)
> 

-- 
Best regards,
IM