From: Sergey Ostanevich <sergos@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 6/8] refactoring: update comment for index_def_check_tuple
Date: Wed, 27 Nov 2019 17:59:56 +0300 [thread overview]
Message-ID: <20191127145956.GF1718@tarantool.org> (raw)
In-Reply-To: <0a91d03b085e9850329480321c857ba628bda915.1574390065.git.i.kosarev@tarantool.org>
Hi!
LGTM.
Sergos
On 22 Nov 05:46, Ilya Kosarev wrote:
> Originally index_def_check_tuple comment said that it throws a nice
> error. Since refactoring: remove exceptions from
> index_def_new_from_tuple (90ac0037f6cae587d8ca589dbe45c58e67f05657)
> it returns an error. Now it is clearly specified in the comment.
>
> Part of #4247
> ---
> src/box/alter.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index 4b3bbca31..684b93798 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -159,7 +159,7 @@ index_def_check_sequence(struct index_def *index_def, uint32_t sequence_fieldno,
>
> /**
> * Support function for index_def_new_from_tuple(..)
> - * Checks tuple (of _index space) and sets a nice diag if it is invalid
> + * Checks tuple (of _index space) and returns an error if it is invalid
> * Checks only types of fields and their count!
> */
> static int
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-11-27 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 2:46 [Tarantool-patches] [PATCH v5 0/8] refactoring: remove exceptions from triggers follow-ups Ilya Kosarev
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 1/8] refactoring: wrap new operator calls in triggers Ilya Kosarev
2019-11-26 15:07 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 2/8] refactoring: specify struct name in allocation diagnostics Ilya Kosarev
2019-11-27 13:25 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 3/8] refactoring: recombine error conditions in triggers Ilya Kosarev
2019-11-27 13:28 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 4/8] refactoring: set diagnostics if sequence_by_id fails Ilya Kosarev
2019-11-27 13:40 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 5/8] refactoring: clear triggers from fresh exceptions Ilya Kosarev
2019-11-27 14:59 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 6/8] refactoring: update comment for index_def_check_tuple Ilya Kosarev
2019-11-27 14:59 ` Sergey Ostanevich [this message]
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 7/8] refactoring: remove redundant line in txn_alter_trigger_new Ilya Kosarev
2019-11-27 15:00 ` Sergey Ostanevich
2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 8/8] refactoring: remove try..catch wrapper around trigger->run Ilya Kosarev
2019-11-27 15:01 ` Sergey Ostanevich
2019-12-02 7:41 ` [Tarantool-patches] [PATCH v5 0/8] refactoring: remove exceptions from triggers follow-ups Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127145956.GF1718@tarantool.org \
--to=sergos@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 6/8] refactoring: update comment for index_def_check_tuple' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox