From: Mergen Imeev <imeevma@tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET Date: Wed, 27 Nov 2019 15:21:38 +0300 [thread overview] Message-ID: <20191127122138.GB29304@tarantool.org> (raw) In-Reply-To: <20191127113917.GD9233@atlas> On Wed, Nov 27, 2019 at 02:39:17PM +0300, Konstantin Osipov wrote: > * Mergen Imeev <imeevma@tarantool.org> [19/11/27 14:27]: > > > But how are you going to fix it? By making SET statement powerful > > > enough to query a value or by making the sysview updatable? > > > > > Since all settings are saved in a “struct session”, I > > think that I will use the same methods PRAGMA used. The > > system view reads from current_session(), so SET will > > also read from there. > > OK, so you are going to allow SET to return an existing value, > without setting it. Then what is the point of having a view, > if you can both get and set the values using SET statement? > I agree that _vsession_settings can be moved from this issue to another. It is here due to historical reasons - at first it was called _vsql_settings and served as the only way to get SQL setting values. Even now, even if this is still the only way to get the values, it can be transferred to another issue. If we allow to get the setting value using the SET statement, then this is definitely worth doing. However, the basic concept of _vsession_settings is slightly different. As I said earlier, it allows you to get the current values of the session settings from all interfaces. > -- > Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-27 12:21 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-27 10:13 [Tarantool-patches] [PATCH 0/5] Introduce SQL SET statement imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 1/5] sql: remove PRAGMA "count_changes" imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 2/5] sql: remove PRAGMA "short_column_names" imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 3/5] temporary: disable boolean.test.sql imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET imeevma 2019-11-27 10:45 ` Mergen Imeev 2019-11-27 10:51 ` Konstantin Osipov 2019-11-27 11:05 ` Mergen Imeev 2019-11-27 11:10 ` Konstantin Osipov 2019-11-27 11:24 ` Mergen Imeev 2019-11-27 11:39 ` Konstantin Osipov 2019-11-27 12:21 ` Mergen Imeev [this message] 2019-11-27 12:49 ` Konstantin Osipov 2019-11-27 13:01 ` Mergen Imeev 2019-11-27 14:03 ` Nikita Pettik 2019-11-27 21:50 ` Konstantin Osipov 2019-11-27 23:22 ` Vladislav Shpilevoy 2019-11-28 12:31 ` Konstantin Osipov 2019-11-28 14:01 ` Nikita Pettik 2019-11-28 15:52 ` Konstantin Osipov 2019-11-27 23:18 ` Vladislav Shpilevoy 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 5/5] sql: refactor PRAGMA-related code imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191127122138.GB29304@tarantool.org \ --to=imeevma@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox