From: Konstantin Osipov <kostja.osipov@gmail.com> To: Mergen Imeev <imeevma@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET Date: Wed, 27 Nov 2019 14:10:30 +0300 [thread overview] Message-ID: <20191127111030.GB9233@atlas> (raw) In-Reply-To: <20191127110532.GA16764@tarantool.org> * Mergen Imeev <imeevma@tarantool.org> [19/11/27 14:07]: > > Usually, if one allows SET statement, SET option_name (without > > "= new_value") prints the current setting. This does the job and > > makes the "_vsettings" system view unnecessary. > > > > Don't you think that having to use one piece of syntax to query a > > value and entirely different piece to assign it is, ehm, > > inconsistent, hard to learn & remember, and eventually hard to > > use? > > > You are right. This was also pointed by Vlad in previous > review: > "2. Ok, but now it looks really unusable when a user want's to > learn an option value. I will create a ticket, if this patchset > will be pushed and nobody will care about usability beforehand." But how are you going to fix it? By making SET statement powerful enough to query a value or by making the sysview updatable? Either way you fix it, the second patch will become unnecessary, don't you think? > Personally, I think this is easy to fix, and your > suggestion is good. In fact, I can fix this in this > patch-set if Vlad and Nikita agree with this solution. -- Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-27 11:10 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-27 10:13 [Tarantool-patches] [PATCH 0/5] Introduce SQL SET statement imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 1/5] sql: remove PRAGMA "count_changes" imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 2/5] sql: remove PRAGMA "short_column_names" imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 3/5] temporary: disable boolean.test.sql imeevma 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET imeevma 2019-11-27 10:45 ` Mergen Imeev 2019-11-27 10:51 ` Konstantin Osipov 2019-11-27 11:05 ` Mergen Imeev 2019-11-27 11:10 ` Konstantin Osipov [this message] 2019-11-27 11:24 ` Mergen Imeev 2019-11-27 11:39 ` Konstantin Osipov 2019-11-27 12:21 ` Mergen Imeev 2019-11-27 12:49 ` Konstantin Osipov 2019-11-27 13:01 ` Mergen Imeev 2019-11-27 14:03 ` Nikita Pettik 2019-11-27 21:50 ` Konstantin Osipov 2019-11-27 23:22 ` Vladislav Shpilevoy 2019-11-28 12:31 ` Konstantin Osipov 2019-11-28 14:01 ` Nikita Pettik 2019-11-28 15:52 ` Konstantin Osipov 2019-11-27 23:18 ` Vladislav Shpilevoy 2019-11-27 10:13 ` [Tarantool-patches] [PATCH 5/5] sql: refactor PRAGMA-related code imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191127111030.GB9233@atlas \ --to=kostja.osipov@gmail.com \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox