From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] errinj: provide 'get' method in Lua
Date: Wed, 27 Nov 2019 11:35:23 +0300 [thread overview]
Message-ID: <20191127083523.GC2752@atlas> (raw)
In-Reply-To: <da7253ee85c0c352d10826775d03ffa46e223ff8.1574810891.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/27 11:15]:
> Error injections are used to simulate an error. They are
> represented as a flag, or a number, and are used in Lua tests. But
> they don't have any feedback. That makes impossible to use the
> injections to check that something has happened. Something very
> needed to be checked, and impossible to check in a different way.
>
> More certainly, the patch is motivated by a necessity to count
> loaded dynamic libraries to ensure, that they are loaded and
> unloaded when expected. This is impossible to do in a platform
> independent way. But an error injection as a debug-only counter
> would solve the problem.
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-27 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 23:29 [Tarantool-patches] [PATCH 0/2] Module is not unloaded on function drop Vladislav Shpilevoy
2019-11-26 23:29 ` [Tarantool-patches] [PATCH 1/2] errinj: provide 'get' method in Lua Vladislav Shpilevoy
2019-11-27 8:35 ` Konstantin Osipov [this message]
2019-11-26 23:29 ` [Tarantool-patches] [PATCH 2/2] func: fix not unloading of unused modules Vladislav Shpilevoy
2019-11-27 8:41 ` Konstantin Osipov
2019-11-27 22:24 ` Vladislav Shpilevoy
2019-12-10 14:22 ` [Tarantool-patches] [PATCH 0/2] Module is not unloaded on function drop Kirill Yukhin
2019-12-11 21:36 ` Alexander Turenko
2019-12-11 22:33 ` Vladislav Shpilevoy
2019-12-19 4:50 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127083523.GC2752@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] errinj: provide '\''get'\'' method in Lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox