From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI)
Date: Wed, 27 Nov 2019 11:31:23 +0300 [thread overview]
Message-ID: <20191127083123.GA2752@atlas> (raw)
In-Reply-To: <20191126211701.mhavpytwkemux3vm@tkn_work_nb>
* Alexander Turenko <alexander.turenko@tarantool.org> [19/11/27 00:17]:
> > > https://github.com/tarantool/tarantool/issues/4427
> >
> > > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4427-move-some-stuff-from-ffi-to-c-api
> >
> > Please add a test case. And an explanation of how the fix solves
> > the issue. The patch is an overkill - the trace is going through
> > box_txn_rollback_to_savepoint, so moving it off ffi to C api
> > should be sufficient.
>
> I would add a bit more context here. The original patch was made by
> Sergey O. and I asked for extracting all related functions into its own
> 'module'. See links below.
>
> https://lists.tarantool.org/pipermail/tarantool-patches/2019-September/006747.html
> https://lists.tarantool.org/pipermail/tarantool-patches/2019-September/000734.html
>
> The moving of just one function should be sufficient, you're right.
> However it is not much more work then extracting all those related
> function into tnx.{c,h,lua}. So I think it worth to do just here.
>
> Are you agree that box/lua/txn.* is more proper place for those
> functions then box/lua/schema.lua?
The move also converts these functions from ffi to plain C.
This is what I am objecting against.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-27 8:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 13:13 Leonid
2019-11-26 21:05 ` Konstantin Osipov
2019-11-26 21:17 ` Alexander Turenko
2019-11-27 8:31 ` Konstantin Osipov [this message]
2019-11-28 8:10 ` Leonid Vasiliev
2019-11-28 12:34 ` Konstantin Osipov
2019-11-28 13:00 ` Igor Munkin
2019-11-28 13:18 ` Konstantin Osipov
2019-11-28 14:03 ` Igor Munkin
2019-11-28 15:58 ` Konstantin Osipov
2019-11-28 18:36 ` Igor Munkin
2019-11-29 5:30 ` Konstantin Osipov
2019-11-29 17:43 ` Igor Munkin
2019-11-29 5:41 ` Konstantin Osipov
2019-11-29 17:37 ` Igor Munkin
2019-12-04 13:05 ` Leonid Vasiliev
2019-12-04 13:15 ` Konstantin Osipov
2019-12-05 8:27 ` Leonid Vasiliev
2020-03-20 18:48 ` Igor Munkin
2020-03-20 19:27 ` Konstantin Osipov
2019-12-11 22:21 ` Alexander Turenko
2019-12-12 8:23 ` Leonid Vasiliev
2020-01-15 17:05 ` Alexander Turenko
2019-12-12 8:49 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127083123.GA2752@atlas \
--to=kostja.osipov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox