From: Igor Munkin <imun@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag
Date: Wed, 27 Nov 2019 00:32:16 +0300 [thread overview]
Message-ID: <20191126213216.GC16745@tarantool.org> (raw)
In-Reply-To: <20191126205800.GD23422@atlas>
Kostja,
Thanks for your remark. I've seen no mention related to the test naming
in our contribution guide[1]. However, your point is valid: *all* other
chunks uses underscores, but not dashes, and the name used in this patch
differs from already existing ones.
Besides, there is another convention mentioned by Vlad and successfully
missed by me sometime.
I see the most convenient solution is adjusting the related test name to
a common style and further naming refactoring within some follow-up
activity.
On 26.11.19, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [19/11/26 19:57]:
> > > rename from test/mmpairs_test.lua
> > > rename to test/mmpairs-tarantool-4560.test.lua
>
> *All* of the source code uses underscores, not dashes for file
> names.
>
>
> --
> Konstantin Osipov, Moscow, Russia
[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/lua_style_guide/#testing
--
Best regards,
IM
next prev parent reply other threads:[~2019-11-26 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:47 Igor Munkin
2019-11-26 16:54 ` Alexander Turenko
2019-11-26 20:58 ` Konstantin Osipov
2019-11-26 21:32 ` Igor Munkin [this message]
2019-11-27 8:32 ` Konstantin Osipov
2019-11-26 21:03 ` Vladislav Shpilevoy
2019-11-26 21:10 ` Igor Munkin
2019-11-27 15:50 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126213216.GC16745@tarantool.org \
--to=imun@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox