Re: [Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag

[Igor Munkin <imun@tarantool.org>]

Vlad,

Thanks for your remark. On second thought I totally agree with you, so
I'll move this chunk one more time. Furthermore, I guess we ought to
move all results of this discussion to Lua style guide[1]:

On 26.11.19, Vladislav Shpilevoy wrote:
> Hi!
> 
> On 26/11/2019 17:54, Alexander Turenko wrote:
> > On Tue, Nov 26, 2019 at 06:47:38PM +0300, Igor Munkin wrote:
> >> The prior name doesn't respect the naming convention used by test-run
> >> thus this chunk was ignored by our testing machinery.
> >>
> >> Part-of tarantool/tarantool#4560
> >>
> >> Signed-off-by: Igor Munkin <imun@tarantool.org>
> >> ---
> >>
> >> Branch: https://github.com/tarantool/luajit/tree/imun/test-name-fixup
> >> Issue: https://github.com/tarantool/tarantool/issues/4560
> >>
> >>
> >>  test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} | 0
> >>  1 file changed, 0 insertions(+), 0 deletions(-)
> >>  rename test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} (100%)
> >>
> >> diff --git a/test/mmpairs_test.lua b/test/mmpairs-tarantool-4560.test.lua
> >> similarity index 100%
> >> rename from test/mmpairs_test.lua
> >> rename to test/mmpairs-tarantool-4560.test.lua
> 
> We have already agreed on, and use a different test name pattern:
> 
>     gh-####-description.test.lua
> 
> Not
> 
>     <description>-####.test.lua.

[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/lua_style_guide/#testing

-- 
Best regards,
IM