* [Tarantool-patches] [PATCH] gitignore: add .idea path
@ 2019-11-25 16:43 Ilya Kosarev
2019-12-17 14:52 ` Alexander Turenko
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Kosarev @ 2019-11-25 16:43 UTC (permalink / raw)
To: tarantool-patches
JetBrains IDEs use .idea folder to store configuration files.
To provide more comfort for it's users .idea folder should be ignored.
---
https://github.com/tarantool/tarantool/tree/i.kosarev/update-gitignore
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index b8ffaca6d..e9508fc43 100644
--- a/.gitignore
+++ b/.gitignore
@@ -26,6 +26,7 @@ CTestTestfile.cmake
Testing/
./build
/build
+.idea/
# Ignore Makefile in the stupid way for `tar --exclude-vcs-ignores`
/Makefile
./Makefile
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] gitignore: add .idea path
2019-11-25 16:43 [Tarantool-patches] [PATCH] gitignore: add .idea path Ilya Kosarev
@ 2019-12-17 14:52 ` Alexander Turenko
2019-12-17 14:54 ` Kirill Yukhin
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Turenko @ 2019-12-17 14:52 UTC (permalink / raw)
To: Ilya Kosarev; +Cc: tarantool-patches
LGTM.
CCed Kirill.
WBR, Alexader Turenko.
On Mon, Nov 25, 2019 at 07:43:04PM +0300, Ilya Kosarev wrote:
> JetBrains IDEs use .idea folder to store configuration files.
> To provide more comfort for it's users .idea folder should be ignored.
> ---
> https://github.com/tarantool/tarantool/tree/i.kosarev/update-gitignore
>
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index b8ffaca6d..e9508fc43 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -26,6 +26,7 @@ CTestTestfile.cmake
> Testing/
> ./build
> /build
> +.idea/
> # Ignore Makefile in the stupid way for `tar --exclude-vcs-ignores`
> /Makefile
> ./Makefile
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] gitignore: add .idea path
2019-12-17 14:52 ` Alexander Turenko
@ 2019-12-17 14:54 ` Kirill Yukhin
2019-12-17 16:05 ` Alexander Turenko
0 siblings, 1 reply; 4+ messages in thread
From: Kirill Yukhin @ 2019-12-17 14:54 UTC (permalink / raw)
To: Alexander Turenko; +Cc: tarantool-patches
Hello,
On 17 дек 17:52, Alexander Turenko wrote:
> LGTM.
>
> CCed Kirill.
Sasha, its obvious. Just commit it.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] gitignore: add .idea path
2019-12-17 14:54 ` Kirill Yukhin
@ 2019-12-17 16:05 ` Alexander Turenko
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Turenko @ 2019-12-17 16:05 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: tarantool-patches
On Tue, Dec 17, 2019 at 05:54:41PM +0300, Kirill Yukhin wrote:
> Hello,
>
> On 17 дек 17:52, Alexander Turenko wrote:
> > LGTM.
> >
> > CCed Kirill.
>
> Sasha, its obvious. Just commit it.
Pushed to master, 2.2 and 1.10.
WBR, Alexander Turenko.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-17 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 16:43 [Tarantool-patches] [PATCH] gitignore: add .idea path Ilya Kosarev
2019-12-17 14:52 ` Alexander Turenko
2019-12-17 14:54 ` Kirill Yukhin
2019-12-17 16:05 ` Alexander Turenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox