Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Stabilize tcp_connect in test_run:cmd()
Date: Mon, 25 Nov 2019 18:31:41 +0300	[thread overview]
Message-ID: <20191125153140.pgpok3phtvqqts7n@tkn_work_nb> (raw)
In-Reply-To: <20191123145012.16074-1-i.kosarev@tarantool.org>

On Sat, Nov 23, 2019 at 05:50:12PM +0300, Ilya Kosarev wrote:
> For some tests, for example, replication/box_set_replication_stress,
> socket.tcp_connect() in test_run:cmd() might sometimes fail when
> running under high load. Now it is fixed.
> 
> Closes #193
> ---
> https://github.com/tarantool/test-run/tree/i.kosarev/gh-193-stabilize-test-run-cmd
> https://github.com/tarantool/test-run/issues/193
> 
>  test_run.lua | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/test_run.lua b/test_run.lua
> index 63dfdef..0d450bd 100644
> --- a/test_run.lua
> +++ b/test_run.lua
> @@ -11,6 +11,9 @@ local clock = require('clock')
>  
>  local function cmd(self, msg)
>      local sock = socket.tcp_connect(self.host, self.port)
> +    while sock == nil do
> +        sock = socket.tcp_connect(self.host, self.port)
> +    end
>      local data = msg .. '\n'
>      sock:send(data)

I'm tentative about possibly infinite loop. I know, test-run will fail a
hung test, but it would be better to fail gracefully and provide some
information about an error (is socket.tcp_connect returns something
about?)

Let's consider using wait_cond or, better, set a connection timeout (if
possible).

It also interesting what is the reason of the connection error in the
first place. Whether test-run actually listens at the moment? Maybe it
unable to proceed much incoming connection requests at time?

Please, don't bury youself with that, but look around briefly.

WBR, Alexander Turenko.

  reply	other threads:[~2019-11-25 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 14:50 Ilya Kosarev
2019-11-25 15:31 ` Alexander Turenko [this message]
2019-11-26  0:19   ` Ilya Kosarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125153140.pgpok3phtvqqts7n@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Stabilize tcp_connect in test_run:cmd()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox