Re: [Tarantool-patches] [PATCH] build: enables DLUAJIT_ENABLE_PAIRSMM by default

[Igor Munkin <imun@tarantool.org>]

Olya,

Thanks for the patch. The changeset LGTM to me, but there are some minor
flaws in the commit message. Please consider my comments below.

On 25.11.19, Olga Arkhangelskaia wrote:

Please, refer one more time to our contribution guide and adjust your
comment regarding it. Simply put, you can just use a bare infinitive for
the predicate used in the commit subject.

> Turns on DLUAJIT_ENABLE_PAIRSMM flag for tarantool build.

The flag name is LUAJIT_ENABLE_PAIRSMM.

> Now pairs/ipairs metamehods are available.

Strictly saying, metamethods names are __pairs and __ipairs.
Typo: s/metamehods/metamethods/.

> 
> Closes 4650

I guess that number sign have to be placed before the issue number to
make this magic line work as described here[1].

> ---
>  cmake/luajit.cmake | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
> index 10df633d5..072db8269 100644
> --- a/cmake/luajit.cmake
> +++ b/cmake/luajit.cmake
> @@ -217,6 +217,7 @@ macro(luajit_build)
>          add_definitions(-DLUAJIT_USE_ASAN=1)
>          set (luajit_ldflags ${luajit_ldflags} -fsanitize=address)
>      endif()
> +    add_definitions(-DLUAJIT_ENABLE_PAIRSMM=1)
>      add_definitions(-DLUAJIT_SMART_STRINGS=1)
>      # Add all COMPILE_DEFINITIONS to xcflags
>      get_property(defs DIRECTORY PROPERTY COMPILE_DEFINITIONS)
> -- 
> 2.20.1 (Apple Git-117)
> 

[1]: https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords

-- 
Best regards,
IM