From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] build: enables DLUAJIT_ENABLE_PAIRSMM by default
Date: Sun, 24 Nov 2019 22:31:36 +0300 [thread overview]
Message-ID: <20191124193136.GK18878@tarantool.org> (raw)
In-Reply-To: <20191122134515.GH18878@tarantool.org>
Olya,
On the second thought, I see this patch delivers exactly the feature
requested in #4560[1]. Please consider to separate it from the provided
patchset and rebase the second patch on it.
Besides, do not forget to append a magic line to the commit message:
| Closes #4560
[1]: https://github.com/tarantool/tarantool/issues/4560
--
Best regards,
IM
next prev parent reply other threads:[~2019-11-24 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 12:03 [Tarantool-patches] [PATCH v2 0/2] protects box.cfg from raw data modification Olga Arkhangelskaia
2019-11-22 12:03 ` [Tarantool-patches] [PATCH v2 1/2] build: enables DLUAJIT_ENABLE_PAIRSMM by default Olga Arkhangelskaia
2019-11-22 13:45 ` Igor Munkin
2019-11-24 19:31 ` Igor Munkin [this message]
2019-11-22 12:03 ` [Tarantool-patches] [PATCH v2 2/2] box: protects box.cfg from raw data modification Olga Arkhangelskaia
2019-11-22 16:31 ` Igor Munkin
2019-11-22 16:55 ` [Tarantool-patches] [PATCH v2 0/2] " Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124193136.GK18878@tarantool.org \
--to=imun@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] build: enables DLUAJIT_ENABLE_PAIRSMM by default' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox