Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] protects box.cfg from raw data modification
Date: Fri, 22 Nov 2019 19:55:44 +0300	[thread overview]
Message-ID: <20191122165543.GJ18878@tarantool.org> (raw)
In-Reply-To: <20191122120347.66629-1-arkholga@tarantool.org>

Olya,

I reviewed both patches within this set and left some comments. Please
consider to rebase you branch on 5d2105b that introduces __pairs
handling to our LuaJIT fork.

On 22.11.19, Olga Arkhangelskaia wrote:
> Patch set enables DLUAJIT_ENABLE_PAIRSMM flag by default and protects
> box.cfg from raw data modification. 
> 
> Branch: https://github.com/tarantool/tarantool/tree/OKriw/gh-2867-raise-on-raw-modifications-of-box.cfg-values
> v1:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012316.html
> 
> Changes in v2:                                                                  
> - deleted second test                                                           
> - deleted unnecessary variables                                                 
> - changed subject/commit msg 
> 
> Olga Arkhangelskaia (2):
>   build: enables DLUAJIT_ENABLE_PAIRSMM by default
>   box: protects box.cfg from raw data modification
> 
>  cmake/luajit.cmake        |  1 +
>  src/box/lua/load_cfg.lua  | 14 +++++++++++++-
>  test/box-tap/cfg.test.lua | 11 ++++++++++-
>  3 files changed, 24 insertions(+), 2 deletions(-)
> 
> -- 
> 2.20.1 (Apple Git-117)
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2019-11-22 16:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 12:03 Olga Arkhangelskaia
2019-11-22 12:03 ` [Tarantool-patches] [PATCH v2 1/2] build: enables DLUAJIT_ENABLE_PAIRSMM by default Olga Arkhangelskaia
2019-11-22 13:45   ` Igor Munkin
2019-11-24 19:31     ` Igor Munkin
2019-11-22 12:03 ` [Tarantool-patches] [PATCH v2 2/2] box: protects box.cfg from raw data modification Olga Arkhangelskaia
2019-11-22 16:31   ` Igor Munkin
2019-11-22 16:55 ` Igor Munkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122165543.GJ18878@tarantool.org \
    --to=imun@tarantool.org \
    --cc=arkholga@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/2] protects box.cfg from raw data modification' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox