From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] func: fix use after free on function unload
Date: Thu, 21 Nov 2019 20:30:00 +0300 [thread overview]
Message-ID: <20191121173000.ssqnv5d5lioksdnd@tarantool.org> (raw)
In-Reply-To: <8a0ed2a5af17c887c8ca13f406852f76f742adb4.1573045803.git.v.shpilevoy@tarantool.org>
Hello,
On 06 ноя 16:12, Vladislav Shpilevoy wrote:
> Functions are stored in lists inside module objects. Module
> objects are stored in a hash table, where key is a package name.
> But the key was a pointer at one of module's function definition
> object. Therefore, when that function was deleted, its freed
> package name memory was still in the hash key, and could be
> accessed, when another function was deleted.
>
> Now module does not use memory of its functions, and keep a copy
> of the package name.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/func-unload-use-after-free
> No issue.
The patch LGTM. I've checked it into 1.10, 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-11-21 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:12 Vladislav Shpilevoy
2019-11-21 17:30 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121173000.ssqnv5d5lioksdnd@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] func: fix use after free on function unload' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox