Re: [Tarantool-patches] [PATCH 0/6] Synchronous replication preparation

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Georgy Kirichenko <georgy@tarantool.org> [19/11/19 19:06]:
> This patchset contains 6 patches and includes some refactoring
> and synchronous replication preparation.
> 
> First three patches provides coio, recovery and xstream
> refactoring which got rid of exceptions. This makes 
> corresponding facilities C-compliant and enables its usage
> from a wal source.
> 
> Fourth patch fixes a rare vinyl error which manifests itself while
> transactional recovery as there is no data change and vy_tx log
> tends to be empty.
> 
> Fifth patch improves recovery journal making them able to track
> recovery vclock. This enables the last patch which implements
> transactional recovery (either local wal including hot-standby or
> final join). Transactional recovery is essential in case of
> synchronous replication because this both sources (wal and final
> join stream) would contain written but not yet committed
> transaction and we will be in duty to recognize it.

LGTM for the design decisions of the entire series. That is,
I agree the premise and the implementation for the changes in the
patch set are good.

I haven't reviewed the patch set thoroughly, so it either has to
be a second review or I will need to go over the details more
carefully.


-- 
Konstantin Osipov, Moscow, Russia