From: Konstantin Osipov <kostja.osipov@gmail.com> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 1/1] iproto: don't destroy a session during disconnect Date: Sat, 16 Nov 2019 16:07:40 +0300 [thread overview] Message-ID: <20191116130740.GF14490@atlas> (raw) In-Reply-To: <746ed8a74c07907f85db8ec08e9d1937afc44f08.1573864467.git.v.shpilevoy@tarantool.org> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/16 12:48]: > Binary session disconnect trigger yield could lead to use after > free of the session object. That happened because iproto thread > sent two requests to TX thread at disconnect: LGTM, except that I usually try to avoid duplicating state, so do_destroy_on_close looks a bit superfluous, especially since you have another variable - is_destroy_sent. > /** True if destroy message is sent. Debug-only. */ > bool is_destroy_sent; -- Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-16 13:07 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-16 0:35 Vladislav Shpilevoy 2019-11-16 13:07 ` Konstantin Osipov [this message] 2019-11-17 17:47 ` Vladislav Shpilevoy 2019-11-17 17:49 ` Konstantin Osipov 2019-11-17 20:33 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191116130740.GF14490@atlas \ --to=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/1] iproto: don'\''t destroy a session during disconnect' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox