From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid
Date: Thu, 14 Nov 2019 14:20:31 +0300 [thread overview]
Message-ID: <20191114112030.4ct4ngoyiwnugy7d@tarantool.org> (raw)
In-Reply-To: <20191028061936.pujwdwwqrwispj5b@tarantool.org>
Hello,
On 28 окт 09:19, Kirill Yukhin wrote:
> Hello,
>
> On 17 окт 23:16, Vladislav Shpilevoy wrote:
> > Before the patch there was a race in replication
> > password configuration. It was possible that a replica
> > connects to a master with a custom password before
> > that password is actually set. The replica treated the
> > error as critical and exited.
> >
> > But in fact it is not critical. Replica even can
> > withstand absence of a user and keeps reconnecting.
> > Wrong password situation arises from the same problem
> > of non atomic configuration and is fixed the same -
> > keep reconnect attempts if the password was wrong.
> >
> > Closes #4550
> > ---
> > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4550-replication-password-cfg
>
> I've checked your patch into 2.2 and master.
Backported to 1.10 as well.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-11-14 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:16 [Tarantool-patches] " Vladislav Shpilevoy
2019-10-17 22:28 ` Konstantin Osipov
2019-10-17 22:43 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-28 6:19 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
2019-11-14 11:20 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114112030.4ct4ngoyiwnugy7d@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox