From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH rfc] rtree: added variable to store error information
Date: Thu, 14 Nov 2019 14:16:48 +0300 [thread overview]
Message-ID: <20191114111648.GA1574@atlas> (raw)
In-Reply-To: <20191114104947.6195-1-arkholga@tarantool.org>
* Olga Arkhangelskaia <arkholga@tarantool.org> [19/11/14 13:51]:
> There is no error handling during memory allocation operations in
> rtree. This results in SEGV_MAPERR error.
>
> There is any mechanism for error handling in libsalad, because it
> should be independent from tarantool. However, in case of memory
> errors(failed allocation) tarantool should notify user and stop
> execution correctly. Now we immediately return and notify caller through
> variable that error has happened.
> Closes #4916
rtree insert should not get started if it may run out of memory,
since it splits pages and needs to allocate memory on rollback
path.
The proper fix is to not start insert operation if there is no
memory.
--
Konstantin Osipov, Moscow, Russia
prev parent reply other threads:[~2019-11-14 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 10:49 Olga Arkhangelskaia
2019-11-14 11:16 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114111648.GA1574@atlas \
--to=kostja.osipov@gmail.com \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH rfc] rtree: added variable to store error information' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox