From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] app/argparse: expect no value for a boolean option
Date: Wed, 13 Nov 2019 07:33:59 +0300 [thread overview]
Message-ID: <20191113043358.GA1534@atlas> (raw)
In-Reply-To: <7d91f7dc-99ac-5c05-8ac1-e256f8dde393@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/13 07:15]:
> >>> As I see the first and the second variants are used across tarantool's
> >>> built-in Lua code. You are right, third one, which I personally prefer,
> >>> is not used within the project.
> >>
> >> There is no options. The first is the only standard in our code. If the
> >> second one is used somewhere, then it is incorrect, or is a third-party
> >> library with own code style.
> >
> > I see no mentions about this (at least there is nothing about this in
> > our Lua Style Guide on the website) as well as I see no dominant style
> > across our Lua code.
> >
> > What is the source of your information?
> >
>
> I remember, that I tried once to use a not aligned multiline 'if' and
> was said/emailed by you, or Roman T., or Vladimir D., or by Kostja O.,
> that in Lua we need to stick to the same rules as in C about alignment.
there is lua coding style that was added by Eugene. I believe it
is even online in the docs:
https://www.tarantool.io/en/doc/1.10/dev_guide/lua_style_guide/
The code should stick to it.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-13 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 0:39 Alexander Turenko
2019-11-11 22:25 ` Vladislav Shpilevoy
2019-11-12 17:40 ` Alexander Turenko
2019-11-12 20:41 ` Vladislav Shpilevoy
2019-11-12 21:03 ` Alexander Turenko
2019-11-12 21:33 ` Vladislav Shpilevoy
2019-11-13 4:33 ` Konstantin Osipov [this message]
2019-11-13 8:40 ` Alexander Turenko
2019-11-15 0:18 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113043358.GA1534@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] app/argparse: expect no value for a boolean option' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox