From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] json: fix assert typo in json_path_cmp()
Date: Tue, 12 Nov 2019 15:43:25 +0300 [thread overview]
Message-ID: <20191112124325.GA96411@tarantool.org> (raw)
In-Reply-To: <20191112100520.ew3fj3bt4p5wkj6d@tarantool.org>
On 12 Nov 13:05, Kirill Yukhin wrote:
> Hello,
>
> On 11 ноя 18:06, Nikita Pettik wrote:
> > 284 int
> > 285 json_path_cmp(const char *a, int a_len, const char *b, int b_len,
> > 286 int index_base)
> > 287 {
> >
> > ...
> >
> > 304 /* Paths a and b must be valid. */
> > 305 assert(rc_b == 0 && rc_b == 0);
> >
> > Obviously (according to the comment) author implied that both rc_a == 0
> > and rc_b == 0. Let's fix this small typo.
>
> Just check it in as obvious.
Ok, pushed to master.
> --
> Regards, Kirill Yukhin
prev parent reply other threads:[~2019-11-12 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 15:06 Nikita Pettik
2019-11-12 10:05 ` Kirill Yukhin
2019-11-12 12:43 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112124325.GA96411@tarantool.org \
--to=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] json: fix assert typo in json_path_cmp()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox