Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Admin universe access
Date: Tue, 12 Nov 2019 12:37:37 +0300	[thread overview]
Message-ID: <20191112093737.25ubvsiy3k6leeej@tarantool.org> (raw)
In-Reply-To: <cover.1572644348.git.v.shpilevoy@tarantool.org>

Hello,

On 01 ноя 22:42, Vladislav Shpilevoy wrote:
> The patchset makes so the admin user never can loose its universe
> access rights. Apparently, Tarantool can't even bootstrap nor
> recovery without universe granted to the admin, because this user
> owns the fibers doing recovery and bootstrap.
> 
> First patch fixes the problem, which was revealed by the online
> credentials update patch. Appeared, that admin user is very
> fragile, and any update of its rights, before universe was
> recovered, led to recovery/bootstrap error.
> 
> The second patch makes it impossible to break the admin user
> explicitly.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4606-replication-universe-v4
> Issue: https://github.com/tarantool/tarantool/issues/4606
> 
> Vladislav Shpilevoy (2):
>   replication: don't drop admin super privileges

I've checked the patch into 1.10, 2.1, 2.2 and master.

>   access: forbid to drop admin's universe access

I've checked the patch into master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2019-11-12  9:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 21:42 Vladislav Shpilevoy
2019-11-01 21:42 ` [Tarantool-patches] [PATCH 1/2] replication: don't drop admin super privileges Vladislav Shpilevoy
2019-11-05 12:40   ` Vladislav Shpilevoy
2019-11-05 18:20   ` Konstantin Osipov
2019-11-01 21:42 ` [Tarantool-patches] [PATCH 2/2] access: forbid to drop admin's universe access Vladislav Shpilevoy
2019-11-05 18:21   ` Konstantin Osipov
2019-11-12  9:37 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112093737.25ubvsiy3k6leeej@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Admin universe access' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox