From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] box: don't allow referenced collation to be dropped
Date: Tue, 12 Nov 2019 00:50:02 +0300 [thread overview]
Message-ID: <20191111215002.GC25103@atlas> (raw)
In-Reply-To: <20191111135246.79818-1-korablev@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [19/11/11 21:27]:
> This patch fixes one debt related to collations: collation is not allowed
> to be dropped until at least one space format or index references to it.
> Otherwise, we may face situation when collation doesn't exist anymore,
> but space has references to it (in-memory DD objects are not updated on
> collation alter). To achieve this we simply iterate over all spaces and
> check their formats and indexes. Despite it takes
> O(space_count * (field_count + index_count)) complexity, it is not a big
> deal: drop of collation is considered to be rare operation. So instead
> of maintaining reference counters we'd better once spend a bit more
> time during drop.
Shouldn't you be able to define json path index on 'collation'
option and use it for lookup instead?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-12 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 13:52 Nikita Pettik
2019-11-11 21:50 ` Konstantin Osipov [this message]
2019-11-11 22:38 ` Vladislav Shpilevoy
2019-11-12 13:24 ` Nikita Pettik
2019-11-13 4:37 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111215002.GC25103@atlas \
--to=kostja.osipov@gmail.com \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: don'\''t allow referenced collation to be dropped' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox