From: Alexander Turenko <alexander.turenko@tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2] build: enable CentOS 8 packaging Date: Fri, 8 Nov 2019 20:34:31 +0300 [thread overview] Message-ID: <20191108173430.j4xijtm57ccl22pc@tkn_work_nb> (raw) In-Reply-To: <20191108162009.GE31677@tarantool.org> On Fri, Nov 08, 2019 at 07:20:09PM +0300, Igor Munkin wrote: > Sasha Ti. and Sasha Tu., > > Thanks, though I left some minor comments below the polished patch is > totally LGTM. > > Sasha Tu., feel free to proceed. Thanks for review! Pushed to master, 2.2, 2.1 and 1.10. CCed Kirill. > > My variant of the commit message is below. Please, let me know whether > > you are okay with it. I left all points you highlighted and tried to > > make its description more easy to understand w/o much context. > > > > | travis-ci/gitlab-ci: add CentOS 8 > > Minor: build label seems to be more suitable for this changeset. Okay. Changed to 'build: add CentOS 8 into CI / CD'. > > | Eliminated libunwind runtime dependency (and libunwind-devel build > > | dependency) on CentOS 8, because the base system does not provide it. > > | fiber.info() backtraces and printing of a backtrace after a crash will > > | not be available on this system. Hopefully we'll fix it in the future, > > | filed #4611 on this. > Minor: feel free to mention a co-author here cause you both made a huge > work on this issue. Don't sure how to differentiate situations when I should add 'Reviewed-by' and when 'Co-developed-by'. Added the former, because my changes were made in response to Alexander's request to review his patch.
next prev parent reply other threads:[~2019-11-08 17:34 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 4:10 Alexander V. Tikhonov 2019-11-08 15:22 ` Alexander Turenko 2019-11-08 15:28 ` Alexander Tikhonov 2019-11-08 16:20 ` Igor Munkin 2019-11-08 17:34 ` Alexander Turenko [this message] -- strict thread matches above, loose matches on Subject: below -- 2019-11-04 18:41 Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108173430.j4xijtm57ccl22pc@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [Tarantool-patches] [PATCH v2] build: enable CentOS 8 packaging' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox