From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH] box/console: Fix crash in error message Date: Fri, 8 Nov 2019 16:54:16 +0300 [thread overview] Message-ID: <20191108135416.GB2875@uranus> (raw) In-Reply-To: <20191108133607.15747-1-gorcunov@gmail.com> The former message has been dropped by tarantool.org receivers, so lets try to resend... --- When invalid command passed we should print out the excat value, instead due to typo in 96dbc49d097a96af5273cce2b5663db5917f4ea9 we cause a nil dereference. Reported-by: Mergen Imeev <imeevma@tarantool.org> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/lua/console.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua index 52df67465..d4d8ec984 100644 --- a/src/box/lua/console.lua +++ b/src/box/lua/console.lua @@ -323,7 +323,7 @@ local function preprocess(storage, line) end if items == nil then local msg = "Invalid command \\%s. Type \\help for help." - return format(false, msg:format(items[1])) + return format(false, msg:format(line)) end return operators[items[1]](storage, unpack(items)) end -- 2.20.1
next prev parent reply other threads:[~2019-11-08 13:54 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-08 13:36 Cyrill Gorcunov 2019-11-08 13:54 ` Cyrill Gorcunov [this message] 2019-11-08 21:44 ` Alexander Turenko 2019-11-08 21:46 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108135416.GB2875@uranus \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] box/console: Fix crash in error message' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox