From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] tarantoolctl --show-system
Date: Thu, 7 Nov 2019 04:36:00 +0300 [thread overview]
Message-ID: <20191107013559.ng7rdtgggprv4etr@tkn_work_nb> (raw)
In-Reply-To: <cover.1568847349.git.v.shpilevoy@tarantool.org>
This patchset formally fixes the issue, however I prefer to use the
following syntax:
$ tarantoolctl cat --show-system 00000000000000000000.snap
rather then one of the following
$ tarantoolctl cat --show-system true 00000000000000000000.snap
$ tarantoolctl cat --show-system 1 00000000000000000000.snap
$ tarantoolctl cat --show-system=true 00000000000000000000.snap
$ tarantoolctl cat --show-system=1 00000000000000000000.snap
I reopened the issue and will prepare the patch soon.
WBR, Alexander Turenko.
On Thu, Sep 19, 2019 at 01:00:29AM +0200, Vladislav Shpilevoy wrote:
> The patchset fixes incorrect handling of flag-parameters in tarantoolctl and its
> module - argparse.
>
> The only flag parameter now is '--show-system'. And an attempt to specify it
> appeared to be quite non-trivial task. It was not possible to set any value for
> this parameter, and it was showing weird error messages. This was because of how
> argparse module, used by tarantoolctl to parse arguments, stored parameters not
> having a value, and how checked boolean parameters.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4076-tarantoolctl-show-system
> Issue: https://github.com/tarantool/tarantool/issues/4076
>
> Vladislav Shpilevoy (2):
> app: fix boolean handling in argparse module
> app: fix error messages for not specified parameters in argparse
>
> src/lua/argparse.lua | 37 ++++++++++-------
> test/app/argparse.result | 84 ++++++++++++++++++++++++++++++++++++--
> test/app/argparse.test.lua | 32 +++++++++++++++
> 3 files changed, 135 insertions(+), 18 deletions(-)
>
> --
> 2.20.1 (Apple Git-117)
>
parent reply other threads:[~2019-11-07 1:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <cover.1568847349.git.v.shpilevoy@tarantool.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107013559.ng7rdtgggprv4etr@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] tarantoolctl --show-system' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox