From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH 05/15] sql: move sql_finalize() to execute.h Date: Thu, 7 Nov 2019 04:04:45 +0300 [thread overview] Message-ID: <20191107010455.64457-6-korablev@tarantool.org> (raw) In-Reply-To: <20191107010455.64457-1-korablev@tarantool.org> We are going to make prepared statement cache be session local. Hence, when sessions is destroyed we should erase its cache and deallocate each prepared statement in it. As a consequence, we should be able to call sql_finalize() from box/ submodule. So let's move its signature to box/execute.h Need for #2592 --- src/box/ck_constraint.c | 1 + src/box/execute.h | 3 +++ src/box/sql/sqlInt.h | 3 --- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/box/ck_constraint.c b/src/box/ck_constraint.c index d21717f94..6b9d44775 100644 --- a/src/box/ck_constraint.c +++ b/src/box/ck_constraint.c @@ -29,6 +29,7 @@ * SUCH DAMAGE. */ #include "box/session.h" +#include "execute.h" #include "bind.h" #include "ck_constraint.h" #include "errcode.h" diff --git a/src/box/execute.h b/src/box/execute.h index a6000c08b..a85fca5fc 100644 --- a/src/box/execute.h +++ b/src/box/execute.h @@ -89,6 +89,9 @@ struct port_sql { extern const struct port_vtab port_sql_vtab; +int +sql_finalize(struct sql_stmt *stmt); + /** * Prepare (compile into VDBE byte-code) statement. * diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h index 4a28e5fb9..553a48d60 100644 --- a/src/box/sql/sqlInt.h +++ b/src/box/sql/sqlInt.h @@ -510,9 +510,6 @@ sql_value * sql_column_value(sql_stmt *, int iCol); -int -sql_finalize(sql_stmt * pStmt); - /* * Terminate the current execution of an SQL statement and reset * it back to its starting state so that it can be reused. -- 2.15.1
next prev parent reply other threads:[~2019-11-07 1:05 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 1:04 [Tarantool-patches] [PATCH 00/15] sql: prepared statements Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 01/15] sql: remove sql_prepare_v2() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 02/15] sql: refactor sql_prepare() and sqlPrepare() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 03/15] sql: move sql_prepare() declaration to box/execute.h Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 04/15] sql: rename sqlPrepare() to sql_compile() Nikita Pettik 2019-11-07 1:04 ` Nikita Pettik [this message] 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 06/15] port: increase padding of struct port Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 07/15] port: add dump format and request type to port_sql Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 08/15] sql: resurrect sql_bind_parameter_count() function Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 09/15] sql: resurrect sql_bind_parameter_name() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 10/15] sql: add sql_schema_version() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 11/15] sql: introduce sql_stmt_sizeof() function Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 12/15] box: increment schema_version on ddl operations Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 13/15] sql: introduce cache for prepared statemets Nikita Pettik 2019-11-10 23:40 ` Konstantin Osipov 2019-11-11 10:53 ` Nikita Pettik 2019-11-11 18:35 ` Konstantin Osipov 2019-11-12 7:54 ` Georgy Kirichenko 2019-11-12 8:50 ` Konstantin Osipov 2019-11-12 9:30 ` Georgy Kirichenko 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 14/15] box: introduce prepared statements Nikita Pettik 2019-11-10 23:42 ` Konstantin Osipov 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 15/15] netbox: " Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191107010455.64457-6-korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 05/15] sql: move sql_finalize() to execute.h' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox