From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH 09/15] sql: resurrect sql_bind_parameter_name() Date: Thu, 7 Nov 2019 04:04:49 +0300 [thread overview] Message-ID: <20191107010455.64457-10-korablev@tarantool.org> (raw) In-Reply-To: <20191107010455.64457-1-korablev@tarantool.org> We may need to get name of parameter to be bound by its index position. So let's resurrect sql_bind_parameter_name() - put its prototype to sql/sqlInt.h header and update codestyle. Need for #2592 --- src/box/sql/sqlInt.h | 7 +++++++ src/box/sql/vdbeapi.c | 14 ++++---------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h index e6d8bc2e3..1c02bd972 100644 --- a/src/box/sql/sqlInt.h +++ b/src/box/sql/sqlInt.h @@ -685,6 +685,13 @@ sql_bind_zeroblob64(sql_stmt *, int, int sql_bind_parameter_count(sql_stmt *stmt); +/** + * Return the name of a wildcard parameter. Return NULL if the index + * is out of range or if the wildcard is unnamed. + */ +const char * +sql_bind_parameter_name(sql_stmt *stmt, int i); + /** * Perform pointer parameter binding for the prepared sql * statement. diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c index 93b8906e5..482a42288 100644 --- a/src/box/sql/vdbeapi.c +++ b/src/box/sql/vdbeapi.c @@ -1058,18 +1058,12 @@ sql_bind_parameter_count(sql_stmt *stmt) return p->nVar; } -/* - * Return the name of a wildcard parameter. Return NULL if the index - * is out of range or if the wildcard is unnamed. - * - * The result is always UTF-8. - */ const char * -sql_bind_parameter_name(sql_stmt * pStmt, int i) +sql_bind_parameter_name(sql_stmt *stmt, int i) { - Vdbe *p = (Vdbe *) pStmt; - if (p == 0) - return 0; + struct Vdbe *p = (struct Vdbe *) stmt; + if (p == NULL) + return NULL; return sqlVListNumToName(p->pVList, i); } -- 2.15.1
next prev parent reply other threads:[~2019-11-07 1:05 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 1:04 [Tarantool-patches] [PATCH 00/15] sql: prepared statements Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 01/15] sql: remove sql_prepare_v2() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 02/15] sql: refactor sql_prepare() and sqlPrepare() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 03/15] sql: move sql_prepare() declaration to box/execute.h Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 04/15] sql: rename sqlPrepare() to sql_compile() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 05/15] sql: move sql_finalize() to execute.h Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 06/15] port: increase padding of struct port Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 07/15] port: add dump format and request type to port_sql Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 08/15] sql: resurrect sql_bind_parameter_count() function Nikita Pettik 2019-11-07 1:04 ` Nikita Pettik [this message] 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 10/15] sql: add sql_schema_version() Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 11/15] sql: introduce sql_stmt_sizeof() function Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 12/15] box: increment schema_version on ddl operations Nikita Pettik 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 13/15] sql: introduce cache for prepared statemets Nikita Pettik 2019-11-10 23:40 ` Konstantin Osipov 2019-11-11 10:53 ` Nikita Pettik 2019-11-11 18:35 ` Konstantin Osipov 2019-11-12 7:54 ` Georgy Kirichenko 2019-11-12 8:50 ` Konstantin Osipov 2019-11-12 9:30 ` Georgy Kirichenko 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 14/15] box: introduce prepared statements Nikita Pettik 2019-11-10 23:42 ` Konstantin Osipov 2019-11-07 1:04 ` [Tarantool-patches] [PATCH 15/15] netbox: " Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191107010455.64457-10-korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 09/15] sql: resurrect sql_bind_parameter_name()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox