Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] netbox: don't fire on_connect() at schema update
Date: Wed, 6 Nov 2019 16:44:53 +0300	[thread overview]
Message-ID: <20191106134453.nxw3ssua4unvuill@tarantool.org> (raw)
In-Reply-To: <20191106005638.ewlvvnce2en43qid@tkn_work_nb>

Hello,

On 06 ноя 03:56, Alexander Turenko wrote:
> On Tue, Nov 05, 2019 at 07:34:44PM +0300, Kirill Yukhin wrote:
> > Hello,
> > 
> > On 29 окт 22:43, Vladislav Shpilevoy wrote:
> > > There was a bug that netbox at any schema update called
> > > on_connect() triggers. This was due to overcomplicated logic of
> > > handling of changes in the netbox state machine. On_connect() was
> > > fired each time the machine entered 'active' state, even if its
> > > previous states were 'active' and then 'fetch_schema'. The latter
> > > state can be entered many times without reconnects.
> > > 
> > > Another bug was about on_disconnect() - it could be fired even if
> > > the connection never entered active state. For example, if its
> > > first 'fetch_schema' has failed.
> > > 
> > > Now there is an explicit flag showing the machine connect state.
> > > The triggers are fired only when it is changed, on 'active' and on
> > > any error states. Intermediate states (fetch_schema, auth) do not
> > > matter anymore.
> > > 
> > > Thanks @mtrempoltsev for the initial investigation and a draft
> > > fix.
> > > 
> > > Closes #4593
> > > ---
> > > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4593-netbox-on_connect
> > > Issue: https://github.com/tarantool/tarantool/issues/4593
> > 
> > I've checked your patch into 2.2 and master.
> 
> This is the bugfix and should be pushed to 2.1 and 1.10 as well.

Done.

--
Regards, Kirill Yukhin

      reply	other threads:[~2019-11-06 13:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 21:43 Vladislav Shpilevoy
2019-10-29 22:03 ` Cyrill Gorcunov
2019-10-29 23:51 ` Vladislav Shpilevoy
2019-11-05 13:12 ` Alexander Turenko
2019-11-05 14:12   ` Vladislav Shpilevoy
2019-11-05 15:00     ` Alexander Turenko
2019-11-05 16:34 ` Kirill Yukhin
2019-11-06  0:56   ` Alexander Turenko
2019-11-06 13:44     ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106134453.nxw3ssua4unvuill@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] netbox: don'\''t fire on_connect() at schema update' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox