From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/3] session: su left dangling credentials object on stack
Date: Mon, 4 Nov 2019 20:23:32 +0300 [thread overview]
Message-ID: <20191104172332.GC29784@atlas> (raw)
In-Reply-To: <db332f3f69e85d29f6d7e7be95f843db11ce662c.1572558071.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/01 00:39]:
> Box.session.su() worked like following: check user
> existence, create its credentials on the stack, check
> the function, call the function, destroy the
> credentials, restore the old credentials.
>
> After creating the credentials on the stack the
> function check could raise a Lua error. It led to the
> credentials object not being destroyed. As a result,
> user.credentials_list was pointing at invalid memory.
>
> Now there is no errors between creating the temporary
> credentials and its destruction.
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-04 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:42 [Tarantool-patches] [PATCH 0/3] Credentials follow up Vladislav Shpilevoy
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua Vladislav Shpilevoy
2019-11-04 17:20 ` Konstantin Osipov
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name Vladislav Shpilevoy
2019-11-04 17:22 ` Konstantin Osipov
2019-11-05 9:44 ` Vladislav Shpilevoy
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 3/3] session: su left dangling credentials object on stack Vladislav Shpilevoy
2019-11-04 17:23 ` Konstantin Osipov [this message]
2019-11-01 13:54 ` [Tarantool-patches] [PATCH 0/3] Credentials follow up Kirill Yukhin
2019-11-04 17:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104172332.GC29784@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] session: su left dangling credentials object on stack' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox