From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua
Date: Mon, 4 Nov 2019 20:20:05 +0300 [thread overview]
Message-ID: <20191104172005.GA29784@atlas> (raw)
In-Reply-To: <6d8dc914c62ed607d38207ad8983ee28ddfb1bc1.1572558071.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/01 00:39]:
> Some guest user privileges were not revoked in the
> end.
> ---
> test/box/access_sysview.result | 2 +-
> test/box/access_sysview.test.lua | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/box/access_sysview.result b/test/box/access_sysview.result
> index 3072b7394..1f33deceb 100644
> --- a/test/box/access_sysview.result
> +++ b/test/box/access_sysview.result
> @@ -689,7 +689,7 @@ box.session.su('admin')
> ---
> ...
> -- _vcollation is readable anyway.
> -box.schema.user.revoke("guest", "read", "space", "_collation")
> +box.schema.user.revoke("guest", "read, write, alter, execute", "space", "_collation")
> ---
> ...
> box.session.su("guest")
> diff --git a/test/box/access_sysview.test.lua b/test/box/access_sysview.test.lua
> index 031df28aa..17420ae33 100644
> --- a/test/box/access_sysview.test.lua
> +++ b/test/box/access_sysview.test.lua
> @@ -287,7 +287,7 @@ box.space._vcollation:select{0}
> box.session.su('admin')
>
> -- _vcollation is readable anyway.
> -box.schema.user.revoke("guest", "read", "space", "_collation")
> +box.schema.user.revoke("guest", "read, write, alter, execute", "space", "_collation")
> box.session.su("guest")
> #box.space._vcollation:select{}
> session.su('admin')
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-11-04 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:42 [Tarantool-patches] [PATCH 0/3] Credentials follow up Vladislav Shpilevoy
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua Vladislav Shpilevoy
2019-11-04 17:20 ` Konstantin Osipov [this message]
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name Vladislav Shpilevoy
2019-11-04 17:22 ` Konstantin Osipov
2019-11-05 9:44 ` Vladislav Shpilevoy
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 3/3] session: su left dangling credentials object on stack Vladislav Shpilevoy
2019-11-04 17:23 ` Konstantin Osipov
2019-11-01 13:54 ` [Tarantool-patches] [PATCH 0/3] Credentials follow up Kirill Yukhin
2019-11-04 17:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104172005.GA29784@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox