From: Alexander Turenko <alexander.turenko@tarantool.org> To: Roman Khabibov <roman.habibov@tarantool.org> Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account Date: Fri, 1 Nov 2019 18:19:39 +0300 [thread overview] Message-ID: <20191101151939.lewxpitqxzyn6dz6@tkn_work_nb> (raw) In-Reply-To: <ABA786A0-DDF6-4970-828D-442298E5A64D@tarantool.org> > coiox/say: fix getaddrinfo error handling on macOS Typo: coiox -> coio. > >>>> + isnt(strstr(diag_get()->last->errmsg, "getaddrinfo"), NULL, > >>>> + "getaddrinfo error message"); > >>>> + > >>> > >>> I propose to verify the entire error message using > >>> gai_strerror(GAI_AGAIN) and gai_strerror(GAI_NONAME)—just as proposed > >>> above for a log message. > >> I have not found the way, how to carry this macros/enum from the libc header to Lua. > > > > It is possible to add them into socket.c, but anyway it is not worth to > > do this just for a test. Let's check for certain error messages (not for > > just 'getaddrinfo: ' prefix). Again: let's check for certain error messages (not for just 'getaddrinfo: ' prefix). The patch looks okay other then this.
next prev parent reply other threads:[~2019-11-01 15:19 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-25 13:38 [tarantool-patches] [PATCH v2 0/2] " Roman Khabibov 2019-06-25 13:38 ` [tarantool-patches] [PATCH v2 2/2] say: " Roman Khabibov 2019-07-23 14:52 ` [tarantool-patches] " Alexander Turenko 2019-08-05 13:32 ` Roman Khabibov 2019-08-28 21:34 ` Alexander Turenko 2019-08-29 0:51 ` Alexander Turenko [not found] ` <8E98F721-601F-436D-8F0A-5E399D8F7CAB@tarantool.org> 2019-09-06 13:44 ` Alexander Turenko 2019-09-10 12:52 ` Roman Khabibov 2019-11-01 15:19 ` Alexander Turenko [this message] 2019-11-21 17:28 ` [Tarantool-patches] [tarantool-patches] " Roman Khabibov 2019-12-08 19:48 ` Alexander Turenko 2019-12-10 16:25 ` Roman Khabibov 2019-12-18 15:01 ` Alexander Turenko 2019-12-21 17:50 ` Roman Khabibov 2019-12-23 12:56 ` Alexander Turenko 2019-12-23 13:38 ` Alexander Turenko 2019-12-26 17:29 ` Roman Khabibov 2019-12-26 21:05 ` Alexander Turenko 2019-12-27 13:01 ` Roman Khabibov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191101151939.lewxpitqxzyn6dz6@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=roman.habibov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox