Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org,
	tarantool-patches@freelists.org
Subject: Re: [Tarantool-patches] [PATCH v3] replication: fix join vclock obtainment in relay_initial_join
Date: Tue, 29 Oct 2019 20:02:19 +0300	[thread overview]
Message-ID: <20191029170219.GB29443@atlas> (raw)
In-Reply-To: <20191029142356.5196-1-i.kosarev@tarantool.org>

* Ilya Kosarev <i.kosarev@tarantool.org> [19/10/29 19:59]:
> join_vclock test could fail on huge load due to vclock advance
> comparing to an actual WAL. In order to fix this we updated wal_sync so
> that now we can obtain up to date vclock on the flushed state using it.
> It is also better to get max index and index count in single request in
> join_vclock test. With fixes mentioned above it is not fragile anymore.

 I suggest we copy vclock. it's not a good idea to make the two
 threads depend on each other on memory. the relay thread may be
 cancelled while the messasge is in the wal thread.


-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-10-29 17:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 14:23 Ilya Kosarev
2019-10-29 17:02 ` Konstantin Osipov [this message]
2019-10-29 21:20   ` [Tarantool-patches] [PATCH v3] relay: " Ilya Kosarev
2019-10-30 22:22     ` Vladislav Shpilevoy
2019-11-01  0:35       ` Ilya Kosarev
2019-11-01  0:38       ` Ilya Kosarev
2019-10-29 21:20   ` [Tarantool-patches] [PATCH v3] replication: " Ilya Kosarev
2019-10-30 14:33   ` [Tarantool-patches] [tarantool-patches] " Ilya Kosarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029170219.GB29443@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3] replication: fix join vclock obtainment in relay_initial_join' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox