Re: [Tarantool-patches] [PATCH v4 0/4] http: add CURLOPT_ACCEPT_ENCODING option and following improvements

[Alexander Turenko <alexander.turenko@tarantool.org>]

Hi!

Thanks for all that work on the http client.

I mostly okay with the code itself (however there are moments where I'm
tentiative in the patch re CURLOPT_ERRORBUFFER), but I would larify
messages around.

I'll comment each patch separately.

WBR, Alexander Turenko.

On Mon, Oct 28, 2019 at 08:11:11PM +0300, Ilya Kosarev wrote:
> This patchset introduces CURLOPT_ACCEPT_ENCODING option. It brought up
> fix for CURLE_WRITE_ERROR processing and addition of
> CURLE_BAD_CONTENT_ENCODING in curl request code processing, as well as
> enhancement of provided error info for curl request.
> 
> Changes in v2:
> - added docbot request
> - fixed comments
> - enhanced httpc_set_accept_encoding description
> - fixed error handling for unsupported encodings
> 
> Changes in v3:
> - moved error handling for unsupported encodings fix to separate commit
> - added error message obtained using CURLOPT_ERRORBUFFER option
> - added CURLE_BAD_CONTENT_ENCODING for curl request code processing
> 
> Changes in v4:
> - fixed commit message in PATCH 2/4
> - added test case for error message obtained using CURLOPT_ERRORBUFFER option
> 
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4232-curlopt-accept-encoding
> Issues: https://github.com/tarantool/tarantool/issues/4232
>         https://github.com/tarantool/tarantool/issues/4578
>         https://github.com/tarantool/tarantool/issues/4579
> 
> Ilya Kosarev (4):
>   http: add CURLOPT_ACCEPT_ENCODING option
>   http: remove redundant & incorrect case for curl_request code
>   http: enrich httpc_request with curl error message buffer
>   http: add CURLE_BAD_CONTENT_ENCODING case for curl_request code
> 
>  src/httpc.c                       | 24 +++++++++++++++++++-----
>  src/httpc.h                       | 29 +++++++++++++++++++++++++++++
>  src/lua/httpc.c                   |  9 +++++++++
>  src/lua/httpc.lua                 |  2 ++
>  test/app-tap/http_client.test.lua |  4 +++-
>  5 files changed, 62 insertions(+), 6 deletions(-)
> 
> -- 
> 2.17.1
>