From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] replication: fix join vclock obtainment in relay_initial_join
Date: Tue, 29 Oct 2019 00:10:08 +0300 [thread overview]
Message-ID: <20191028211008.GB11163@atlas> (raw)
In-Reply-To: <9c427c1a-9c6f-263b-8cac-99458ccdc8fd@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/10/29 00:08]:
> It looks wrong, that we do begin_checkpoint() but omit
> commit_checkpoint(). I would call commit too. Probably now
> begin() does not allocate any resources, but it may start
> in future, and we will have a leak here.
This would be wrong, too. Wal uses commit_checkpoint() as a singal
that it can recycle wal logs. This is the code Georgy is moving to
GC (but his patch is not in yet).
One way to fix it would be to add vclock out parameter to
wal_sync().
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-10-28 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 12:25 Ilya Kosarev
2019-10-28 21:09 ` Vladislav Shpilevoy
2019-10-28 21:10 ` Konstantin Osipov [this message]
2019-10-29 14:25 ` Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028211008.GB11163@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] replication: fix join vclock obtainment in relay_initial_join' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox