From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/3] sql: make type string case lower everywhere
Date: Mon, 28 Oct 2019 17:23:59 +0300 [thread overview]
Message-ID: <20191028142359.GB86205@tarantool.org> (raw)
In-Reply-To: <da6abb8566ddc528a76640bf3cb3d0774d5233fb.1572211914.git.v.shpilevoy@tarantool.org>
On 27 Oct 22:35, Vladislav Shpilevoy wrote:
> Type was displayed in error messages, was returned in
> meta headers, and a type string is a result of
> typeof() SQL function.
>
> Typeof() always returns lower case type string; meta
> contained upper case type; error messages contained
> both.
>
> It was necessary to choose one case for everything,
> and the lower one was chosen. It allows not to break
> typeof() function which actually might be used by
> someone.
>
> Part of #4462
CI status is negative: sql/bind.test.lua fails. Please, update result file.
The rest is OK as trivial. I want Kirill to look at this change and give
explicit ack for this change. In the latter case, it can be pushed out of order.
next prev parent reply other threads:[~2019-10-28 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 21:35 [Tarantool-patches] [PATCH 0/3] Booleans and lower vs upper Vladislav Shpilevoy
2019-10-27 21:35 ` [Tarantool-patches] [PATCH 1/3] sql: LENGTH function accepts boolean Vladislav Shpilevoy
2019-10-27 21:35 ` [Tarantool-patches] [PATCH 2/3] sql: CAST(<boolean> AS TEXT) returns lowercase Vladislav Shpilevoy
2019-10-28 14:08 ` Nikita Pettik
2019-10-28 21:48 ` Vladislav Shpilevoy
2019-10-27 21:35 ` [Tarantool-patches] [PATCH 3/3] sql: make type string case lower everywhere Vladislav Shpilevoy
2019-10-28 14:23 ` Nikita Pettik [this message]
2019-10-28 21:45 ` Vladislav Shpilevoy
2019-11-07 12:40 ` Nikita Pettik
2019-10-30 23:28 ` [Tarantool-patches] [PATCH 0/3] Booleans and lower vs upper Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028142359.GB86205@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] sql: make type string case lower everywhere' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox