From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH 0/2] JSON update pre-preparation
Date: Mon, 28 Oct 2019 10:52:49 +0300 [thread overview]
Message-ID: <20191028075249.3ued3ok4t3jjsgxy@tarantool.org> (raw)
In-Reply-To: <cover.1572043528.git.v.shpilevoy@tarantool.org>
Hello,
On 26 окт 00:53, Vladislav Shpilevoy wrote:
> The patchset is a preparation for the JSON update preparation.
>
> The main commit is the second one. It renames internals of
> tuple_update.c from update_* to xrow_update_*.
>
> Why it is done - see the commit message.
>
> After we decide on naming of update structures and functions, I
> will rebase the main JSON preparation patch
> (gerold103/gh-1261-update-json-preparation-3) on new names.
>
> This patchset is actually an RFC, because I don't like
> xrow_update_ prefix. It is bulky, too long, and most of the names,
> having it, look unclear.
>
> I would like to either keep update_ prefix, or use xupdate_ - both
> are better than xrow_update_, IMO. But actually I don't really
> care already, so I will name it whatever helps to push it.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-4
> Issue: https://github.com/tarantool/tarantool/issues/1261
I've checked your patch set into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-10-28 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 22:53 [Tarantool-patches] " Vladislav Shpilevoy
2019-10-25 22:53 ` [Tarantool-patches] [PATCH 1/2] rope: fix rope name template Vladislav Shpilevoy
2019-10-28 7:32 ` Konstantin Osipov
2019-10-25 22:53 ` [Tarantool-patches] [PATCH 2/2] tuple: rename update to xrow_update in tuple_update.c Vladislav Shpilevoy
2019-10-28 7:33 ` Konstantin Osipov
2019-10-28 7:52 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028075249.3ued3ok4t3jjsgxy@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] [PATCH 0/2] JSON update pre-preparation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox