Re: [Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 26 окт 04:01, Alexander Turenko wrote:
> This patchset fixes two problems with building of tarantool on different
> OSes:
> 
> - https://github.com/tarantool/tarantool/issues/4490
>   "FreeBSD compilation failing due to curl dependencies"
> - https://github.com/tarantool/tarantool/issues/4587
>   "build: failed to link on MacOS with GNU binutils in PATH"
> 
> The first patch handles several problems with our libcurl build that we
> observes on FreeBSD. In brief, it ensures that we use the same OpenSSL
> library and headers as for tarantool's crypto module as well as for
> libcurl build and also ensures that the headers and the library are from
> the same 'prefix' directory. Those changes reveal several other build
> problems (including one on Mac OS) and I fixed them within this patch.
> 
> The second patch fixes the problem on Mac OS when different toolchains
> can be choosen for building tarantool, libluajit.a and libcurl.a. It is
> not a side effect of the first patch: current master is affected too.
> 
> I already sent the first patch, but decided to investigate the new
> problem on Mac OS and base the fix on the work that was done for
> FreeBSD. The first patch got LGTMs from Igor M. and Alexander Tikh. and
> was not changed except one comment that clarifies why LIBCURL_CFLAGS /
> LIBCURL_CPPFLAGS contain only -isysroot=<SDK_PATH> option.
> 
> The patchset is here:
> 
> https://github.com/tarantool/tarantool/commits/Totktonada/gh-4490-fix-freebsd-openssl-linking-problems-full-ci

I've checked your patch set into 1.10, 2.1, 2.2 and master.

--
Regards, Kirill Yukhin