* Re: [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping [not found] ` <20191025074012.GC2511@uranus.lan> @ 2019-10-25 9:53 ` Alexander Turenko 2019-10-25 10:15 ` Cyrill Gorcunov 2019-11-01 12:49 ` Alexander Turenko 1 sibling, 1 reply; 3+ messages in thread From: Alexander Turenko @ 2019-10-25 9:53 UTC (permalink / raw) To: Cyrill Gorcunov; +Cc: tml, tarantool-patches On Fri, Oct 25, 2019 at 10:40:12AM +0300, Cyrill Gorcunov wrote: > On Fri, Oct 25, 2019 at 03:00:22AM +0300, Alexander Turenko wrote: > > > > Should not we wait for ';\n'? > > Strictly speaking ; is only eos, the newline is needed for terminal > driver. But currently what we have might confuse a user, so I think > you are probably right. Need to think and revisit this moment. Thanks! We use this approach for reading of a client input on a remote server: see client_read() in src/box/lua/console.lua ('\r' here to handle telnet connections, see fa1aa01e49f323557fc981f7a76d85f99a9c7990). Those delimiter was introduced before implementing local_check_lua(), which works on a client side (both for local console and a client for a remote console): when a delimiter is not set, we read input line by line and try to parse it as a Lua statement using loadstring(). There are some flaws however: https://github.com/tarantool/tarantool/issues/4082 I suspect the latter approach is not usable for cases where we have no Lua interpreter on a client side (say, for test-run); I mentioned it to provide more broad information. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping 2019-10-25 9:53 ` [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping Alexander Turenko @ 2019-10-25 10:15 ` Cyrill Gorcunov 0 siblings, 0 replies; 3+ messages in thread From: Cyrill Gorcunov @ 2019-10-25 10:15 UTC (permalink / raw) To: Alexander Turenko; +Cc: tml, tarantool-patches On Fri, Oct 25, 2019 at 12:53:12PM +0300, Alexander Turenko wrote: > > There are some flaws however: > https://github.com/tarantool/tarantool/issues/4082 > > I suspect the latter approach is not usable for cases where we have no > Lua interpreter on a client side (say, for test-run); I mentioned it to > provide more broad information. Thanks a huge! Will read. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping [not found] ` <20191025074012.GC2511@uranus.lan> 2019-10-25 9:53 ` [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping Alexander Turenko @ 2019-11-01 12:49 ` Alexander Turenko 1 sibling, 0 replies; 3+ messages in thread From: Alexander Turenko @ 2019-11-01 12:49 UTC (permalink / raw) To: Cyrill Gorcunov; +Cc: tml, tarantool-patches On Fri, Oct 25, 2019 at 10:40:12AM +0300, Cyrill Gorcunov wrote: > On Fri, Oct 25, 2019 at 03:00:22AM +0300, Alexander Turenko wrote: > > > > Should not we wait for ';\n'? > > Strictly speaking ; is only eos, the newline is needed for terminal > driver. But currently what we have might confuse a user, so I think > you are probably right. Need to think and revisit this moment. Thanks! Filed https://github.com/tarantool/tarantool/issues/4603 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-01 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191004074926.17329-1-gorcunov@gmail.com>
[not found] ` <20191004074926.17329-4-gorcunov@gmail.com>
[not found] ` <20191025000022.msnkmuyh3mydxxim@tkn_work_nb>
[not found] ` <20191025074012.GC2511@uranus.lan>
2019-10-25 9:53 ` [Tarantool-patches] [PATCH 3/7] box/console: Add explicit output EOS mapping Alexander Turenko
2019-10-25 10:15 ` Cyrill Gorcunov
2019-11-01 12:49 ` Alexander Turenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox