From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: cancel replica joining thread at exit
Date: Thu, 24 Oct 2019 08:09:55 +0300 [thread overview]
Message-ID: <20191024050955.g47ddjvw3mh33lls@tarantool.org> (raw)
In-Reply-To: <20191015155007.6834-1-i.kosarev@tarantool.org>
Hello,
On 15 окт 18:50, Ilya Kosarev wrote:
> If a tarantool instance exits while joining replica is in progress,
> the replica joining thread can access already freed data resulting
> in a crash. Let's fix this the same way we did for checkpoint thread
> - simply cancel the thread forcefully and wait for it to terminate.
>
> Closes #4528
> ---
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4528-fix-shutdown-on-replica-join
> https://github.com/tarantool/tarantool/issues/4528
I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-10-24 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:50 Ilya Kosarev
2019-10-21 13:57 ` [Tarantool-patches] [tarantool-patches] " Alexander Tikhonov
2019-10-22 21:28 ` Vladislav Shpilevoy
2019-10-23 12:59 ` [Tarantool-patches] " Ilya Kosarev
2019-10-23 20:55 ` Vladislav Shpilevoy
2019-10-24 5:09 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024050955.g47ddjvw3mh33lls@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: cancel replica joining thread at exit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox